[Distributions] Add Binomial distribution & DiscretelyDistributed trait#3
Merged
forfudan merged 8 commits intomojomath:mainfrom Mar 7, 2026
Merged
Conversation
Member
Author
|
@forfudan I have currently made the field |
Member
|
@shivasankarka |
forfudan
approved these changes
Mar 7, 2026
Member
forfudan
left a comment
There was a problem hiding this comment.
Add checks for logpmf and cdf when k < 0.
For _log_binomial_coefficient(n: UInt, ...), change it to n: Int to be consistent with other cases. We may consider adding raises in future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Traits
DiscretelyDistributedtrait has been implemented with basic method for the distributions. Any integral value must be of typeIntfor consistency.Binomial
Binomialdistribution has been implemented and it conforms toDiscretelyDistributed.Binomialdistribution.